Incorrect param sent to Time.parse in CoreExt
Incorrect param sent to Time.parse in CoreExt `Time.parse` takes a date as first param and defaults to `Time.now` for the second param. `true` was being passed into `Time.parse` and returning `nil` in...
View ArticleTest on Ruby 2.2 and auto test on patched versions
Test on Ruby 2.2 and auto test on patched versions
View ArticleFix flickering tests
Fix flickering tests Global state is bad, but you gotta be green before you can make things better.
View ArticleRemove stale Travis config
Remove stale Travis config This told Travis to leave out a group called tools, but we don't have a group by that name.
View ArticleAllow JRuby to fail (for now)
Allow JRuby to fail (for now) The first step to JRuby support is getting Travis to properly run the tests, now I just have to figure out why they're failing. :laughing:
View ArticleSimplify Time parsing extension
Simplify Time parsing extension Rubocop wasn't happy with how complicated this implementation was so I simplified it. I'm still not super happy with it, but #313 changes a lot of this anyway so making...
View ArticleUse more simple `parse` method when possible
Use more simple `parse` method when possible I'm not sure why I reached for `parse_with` here when `parse` was just as good. In fact, I was duplicating the error handling for not being able to find a...
View ArticleSimplify new entry conditional
Simplify new entry conditional I'm not going to lie, it was very fun to tinker with this for an hour or so. I think what I've landed on here is actually pretty readable!
View ArticleAdd Rubocop to default rake task
Add Rubocop to default rake task I also added my favorite option for Rubocop so that I could get rid of the config file.
View Article
